Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant multi_line_output = 3 from "Compatibility with black" #1858

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Remove redundant multi_line_output = 3 from "Compatibility with black" #1858

merged 1 commit into from
Nov 26, 2021

Conversation

jdufresne
Copy link
Collaborator

According to the profiles documentation:
https://pycqa.github.io/isort/docs/configuration/profiles.html

The black profiles contains: "multi_line_output = 3". Avoid confusion on
the "Compatibility with black" page by not adding a redundant option.
The reader may believe the extra "multi_line_output" is required.

This came up in a real world scenario:
pypa/pyproject-hooks#137 (comment)

According to the profiles documentation:
https://pycqa.github.io/isort/docs/configuration/profiles.html

The black profiles contains: "multi_line_output = 3". Avoid confusion on
the "Compatibility with black" page by not adding a redundant option.
The reader may believe the extra "multi_line_output" is required.

This came up in a real world scenario:
pypa/pyproject-hooks#137 (comment)
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #1858 (8924a65) into main (3ddd965) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1858   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          38       38           
  Lines        3046     3046           
  Branches      725      725           
=======================================
  Hits         3041     3041           
  Misses          1        1           
  Partials        4        4           

@timothycrosley
Copy link
Member

Thanks for fixing this! I could see how that could be confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants