Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only skip real comments #1833

Merged
merged 4 commits into from
Oct 30, 2021
Merged

only skip real comments #1833

merged 4 commits into from
Oct 30, 2021

Conversation

chrisdecker1201
Copy link
Contributor

I had the issue that I wrote a test for darker (akaihola/darker#230) where I get an error because isort is handling every # isort: skip_file even if this is not a real comment.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1833 (3c5da48) into main (0c24ace) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1833   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          38       38           
  Lines        3045     3045           
  Branches      724      723    -1     
=======================================
  Hits         3038     3038           
  Misses          2        2           
  Partials        5        5           

@timothycrosley
Copy link
Member

I think the correct thing todo here, is just to be clever about how you define this token in other places, like isort itself is, see:

"isort:" + "skip_file",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants