Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinked paths are excluded from gitignore checks #1773

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

ucodery
Copy link
Collaborator

@ucodery ucodery commented Jul 5, 2021

No description provided.

@ucodery
Copy link
Collaborator Author

ucodery commented Jul 5, 2021

This fixes #1772

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1773 (2bbf393) into main (191e165) will increase coverage by 0.06%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
+ Coverage   99.89%   99.96%   +0.06%     
==========================================
  Files          37       37              
  Lines        2930     2935       +5     
  Branches      695      697       +2     
==========================================
+ Hits         2927     2934       +7     
+ Misses          2        0       -2     
  Partials        1        1              

@ucodery
Copy link
Collaborator Author

ucodery commented Jul 5, 2021

Our company uses a build tool in CI that link a bin dir from the root of the repo to a global private bin dir on the host machine. Before this change, runs of isort had ballooned to a run time of at least 7 minutes. After this change at least 1000 less files were passed to git to check for ignoring and runtime went down to almost 10 seconds.
Also, FYI we have multiple .gitignores at different levels, so a self-contained .gitignore like in #1585 would not have helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants