Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ensure-newline-before-comments argument #1101

Merged

Conversation

StephenBrown2
Copy link
Contributor

Also adds config option from #1000 to the argument list.

Feel free to disregard, if the args list is getting too out of hand.

@codecov-io
Copy link

Codecov Report

Merging #1101 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
+ Coverage    84.63%   84.72%   +0.08%     
===========================================
  Files           42       42              
  Lines         3652     3653       +1     
  Branches       655      655              
===========================================
+ Hits          3091     3095       +4     
+ Misses         423      422       -1     
+ Partials       138      136       -2
Impacted Files Coverage Δ
isort/main.py 72.38% <100%> (+0.13%) ⬆️
isort/wrap_modes.py 93.63% <0%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6306780...6cc047e. Read the comment docs.

@timothycrosley
Copy link
Member

This is great! Happy to have the args a little longer to keep things in sync.

Thanks!

~Timothy

@timothycrosley timothycrosley merged commit 8ada14e into PyCQA:develop Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants