Redundant local name for modified imports

[scop]

isort 5.0.4 changes this

import urllib.parse as parse

...to this:

from urllib import parse as parse

I think as parse is redundant and should not be emitted, but just

from urllib import parse

FWIW pylint will issue useless-import-alias for the duplication.

[jdufresne]

More generally, perhaps isort should remove useless aliases whether isort generated them or not:

input:

from datetime import datetime as datetime

print(datetime.now())

current output: unchanged

expected output:

from datetime import datetime

print(datetime.now())

[scop]

I agree. But for completeness, I've seen documented conventions where those "useless" aliases are actually used to mark an import being part of an API. So e.g. for a module that doesn't use foo itself at all, from bar import foo as foo with the alias serves to note that the import isn't accidental. I can't locate a reference to such a convention at the moment, nor do I actually personally find it a good one, but thought I'd mention it, FWIW.

[timothycrosley]

This is fixed in develop and will be released in the 5.1.0 minor release slated for release by end of month at the latest. As part of this a new remove_redundent_aliases config option has been added - though no alias will now show up by default either way if there was not one present originally.

Thanks!

~Timothy

[timothycrosley]

This has now been deployed to PyPI in the 5.1.0 release, thanks again!

~Timothy