B902: Add exceptions for standard library metaclasses #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperlees
requested changes
Sep 22, 2023
|
I rebased the commit to the latest main branch in the hope that it would retrigger the CI runs, but that didn't work. Now I can no longer see the original CI results :( EDIT: nvmd, I fixed it |
I faced a false positive when deriving my metaclass from ABCMeta, which should be fixed with this commit. I also added EnumMeta to this list, because it was the only other public metaclass in the standard library.
cooperlees
approved these changes
Nov 26, 2023
| @@ -92,7 +92,7 @@ def method(self): | |||
|
|
|||
|
|
|||
| class non_keyword_abcmeta_1(ABCMeta): # safe | |||
| def method(self): | |||
| def method(cls): | |||
There was a problem hiding this comment.
Is there any value to have both method(self) and method2(cls)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced a false positive when deriving my metaclass from ABCMeta, which should be fixed with this commit. I also added EnumMeta to this list, because it was the only other public metaclass in the standard library.