Add new check which finds duplicate except clauses #258
Conversation
|
@cooperlees I just realized that B014 does partially the same job. The difference is, that it doesn't consider multiple except clauses. I would suggest to tune B014 to also consider multiple except's. This would mean that the error message would change. Is that fine? |
|
I think since B014 looks for duplication per exception clause I'm a fan of the more explicit error message of the new B023 stating that it's a redundant clause in a new except. Let me take a look at the wording to ensure this is explicit as it can be. Thanks for asking. |
There was a problem hiding this comment.
Looks good - but tests show we've hit B014 being triggered at the same time. I feel this would be annoying for users. So I feel we either extend B014 or if B023 is hit, clear B014?
- OR, do people like the two explicit errors?
I personally think getting the two lints, since they are so similar annoying - So maybe combining would be preferential?
Also, some minor suggestions in the error output + README.
|
I'm very sorry for the late pickup. Since this is heavily outdated, let me open a new PR |
Closes #254