Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official release still broken with pre-commit (1.7.6?) #293

Open
Eutropios opened this issue Oct 14, 2024 · 3 comments
Open

Official release still broken with pre-commit (1.7.6?) #293

Eutropios opened this issue Oct 14, 2024 · 3 comments
Labels
fresh This is a new issue

Comments

@Eutropios
Copy link

Despite the commit modifying docformatter to allow for it to work with pre-commit 4.0, this commit has not been shipped as an official release. Is there any chance we could get a 1.7.6 release with the latest commit to allow us to continue using docformatter as a pre-commit hook with 4.0?
@github-actions github-actions bot added the fresh This is a new issue label Oct 14, 2024
This was referenced Oct 14, 2024
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 14, 2024
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
segsell added a commit to OpenSourceEconomics/dcegm that referenced this issue Oct 14, 2024
@segsell
Suspend docformatter until package has been fixed by the creators
ec01c12 
PyCQA/docformatter#293
@kafitzgerald kafitzgerald mentioned this issue Oct 14, 2024
Merged
This was referenced Oct 14, 2024
Merged
Closed
@observingClouds observingClouds mentioned this issue Oct 15, 2024
Merged
@alecandido alecandido mentioned this issue Oct 15, 2024
Merged
jshwi added a commit to jshwi/docsig that referenced this issue Oct 15, 2024
@jshwi
chore: remove docformatter from pre-commit
4e284b9 
PyCQA/docformatter#293
Signed-off-by: Stephen Whitlock <[email protected]>
@lkstrp lkstrp mentioned this issue Oct 15, 2024
Merged
This was referenced Oct 15, 2024
Closed
Closed
This was referenced Oct 15, 2024
Closed
Merged
@jaseemjaskp jaseemjaskp mentioned this issue Oct 16, 2024
Merged
@GriceTurrble
Copy link

GriceTurrble commented Oct 17, 2024 •
edited
Loading

Just a note, all that's required for pre-commit's autoupdate is to make a new tag in the repo. If folks want to avoid a full release when there may not be changes to the underlying package, that is.

I propose a v1.7.5-post1?

As a workaround, folks can target rev: "master" in their configs.

Edit: the most recent commit sha can also be used: rev: "eb1df347edd128b30cd3368dddc3aa65edcfac38"

@alecandido alecandido mentioned this issue Oct 17, 2024
Merged
4 tasks
jshwi added a commit to jshwi/jss that referenced this issue Oct 18, 2024
@jshwi
chore: remove docformatter from pre-commit
e85cbe2 
PyCQA/docformatter#293
Signed-off-by: Stephen Whitlock <[email protected]>
@NoraLoose NoraLoose mentioned this issue Oct 18, 2024
Merged
lebrice added a commit to lebrice/SimpleParsing that referenced this issue Oct 18, 2024
@lebrice
Try a fix for broken docformatter pre-commit hook
6da06dd 
- PyCQA/docformatter#293
@lebrice lebrice mentioned this issue Oct 18, 2024
Merged
lebrice added a commit to lebrice/SimpleParsing that referenced this issue Oct 18, 2024
@lebrice
Try a fix for broken docformatter pre-commit hook (#333)
1b53862 
- PyCQA/docformatter#293
@observingClouds observingClouds mentioned this issue Oct 19, 2024
Merged
azmeuk added a commit to yaal-coop/canaille that referenced this issue Oct 19, 2024
@azmeuk
chore: dependencies update
d078407 
temporary fixed pre-commit version because of
PyCQA/docformatter#293
@alecandido alecandido mentioned this issue Oct 20, 2024
Merged
4 tasks
@gjmm07 gjmm07 mentioned this issue Oct 21, 2024
Open
@nfelt14
Copy link

nfelt14 commented Oct 21, 2024

@weibullguy, you were the one who merged the PR that fixed the issue on the master branch. Do you have permissions to create a new tag/release?

This was referenced Oct 22, 2024
Merged
Merged
samuelhwilliams added a commit to communitiesuk/funding-service-design-assessment-store that referenced this issue Oct 24, 2024
@samuelhwilliams
Pin pre-commit docformatter hook
99a4df9 
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
samuelhwilliams added a commit to communitiesuk/funding-service-design-assessment-store that referenced this issue Oct 24, 2024
@samuelhwilliams
Pin pre-commit docformatter hook
4fe806a 
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
hamzabinkhalid pushed a commit to communitiesuk/funding-service-design-assessment-store that referenced this issue Oct 24, 2024
@samuelhwilliams @hamzabinkhalid
Pin pre-commit docformatter hook
7e4016e 
Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
azmeuk added a commit to yaal-coop/canaille that referenced this issue Oct 27, 2024
@azmeuk
chore: fix pre-commit version
ff4a404 
until docformatter hook is fixed
PyCQA/docformatter#293
m-appel added a commit to InternetHealthReport/internet-yellow-pages that referenced this issue Oct 28, 2024
@m-appel
Bump pre-commit versions and pin pre-commit version
e258a0e 
The docformatter hook of pre-commit currently does not work with
pre-commit >=v4.0.0, so pin to an old version for now.

See PyCQA/docformatter#293
azmeuk added a commit to yaal-coop/canaille that referenced this issue Oct 28, 2024
@azmeuk
chore: fix pre-commit version in Gitlab CI
ebbeb13 
Until the docformatter hook is fixed
PyCQA/docformatter#293
@alecandido alecandido mentioned this issue Oct 28, 2024
Merged
@dvarasani-crest dvarasani-crest mentioned this issue Oct 29, 2024
Merged
dvarasani-crest added a commit to splunk/addonfactory-solutions-library-python that referenced this issue Oct 30, 2024
@dvarasani-crest
ci: fix ubuntu version to 22.04 (#399)
148955b 
This PR sets ubuntu version to 22.04 for scripts run with python 3.7.
Reference:
[ADDON-75861](https://splunk.atlassian.net/browse/ADDON-75861)

Python version for pre-commit can not be updated to latest version due
to open issue with the docformatter hook.
Reference: PyCQA/docformatter#289,
PyCQA/docformatter#293
@jkanche
Copy link

jkanche commented Nov 4, 2024

@weibullguy, you were the one who merged the PR that fixed the issue on the master branch. Do you have permissions to create a new tag/release?

Hi, I was wondering if there's any updates on bumping the version?

This was referenced Nov 5, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fresh This is a new issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jkanche @GriceTurrble @nfelt14 @Eutropios