Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort imports #232

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Don't sort imports #232

merged 1 commit into from
Mar 10, 2023

Conversation

fsouza
Copy link
Collaborator

@fsouza fsouza commented Mar 10, 2023

When removing unused imports or breaking up lines, keep the original order.

Users can use other linters/formatters to fix import order (e.g. isort or reorder-python-imports).

Closes #229.

Copy link

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and works with the example on my end~

When removing unused imports or breaking up lines, keep the original
order.

Users can use other linters/formatters to fix import order (e.g. isort
or reorder-python-imports).

Closes #229.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing import resorts imports in a way incompatible with isort
2 participants