Skip to content

Conversation

JigyasuRajput
Copy link
Contributor

Cambios propuestos:

  • Added help text to the URL input form to guide users.
  • Fixed validation to automatically prepend https:// to URLs if missing

Temas tratados:

Pruebas realizadas:

  • Built and ran the application inside a Docker container without errors.
  • Tested the URL input form with valid and invalid URLs (with and without https://).
  • Verified the expected behavior in the Dockerized environment.

Cómo probar los cambios:

  1. Navigate to the form with the URL input field.
  2. Enter a URL without https:// (e.g., www.github.com) and save.
  3. Verify that https:// is automatically added to the URL and saved correctly

Gracias por contribuir con el proyecto.

Estamos pendiente de revisar los cambios propuestos.

Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@facundobatista facundobatista enabled auto-merge (squash) December 24, 2024 20:49
@facundobatista
Copy link
Member

Hello! It looks a test is faling?

Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test

@JigyasuRajput
Copy link
Contributor Author

I've made the requested changes and ensured the tests are passing. Let me know if anything else needs to be addressed

@eduzen
Copy link
Member

eduzen commented Jan 20, 2025

I don't see any change in this pr, only some empty lines removed @JigyasuRajput

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pantalla creacion de empresa campo url poco específico

3 participants