Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bits per coded sample #1330

Closed
wants to merge 3 commits into from
Closed

Conversation

JoeSchiff
Copy link
Contributor

Tests for #1203.

It seems there are 2 properties in ffmpeg called bits_per_coded_sample:

AVCodecParameters::bits_per_coded_sample
https://ffmpeg.org/doxygen/6.0/structAVCodecParameters.html#a3866500f51fabfa90faeae894c6e955c

AVCodecContext::bits_per_coded_sample
https://ffmpeg.org/doxygen/6.0/structAVCodecContext.html#a5273a8cf73ef598d632c6eee1379d5ad

I assume we want the one from AVCodecContext, so I changed the docstring to match.

I wrote 3 tests for the QT RLE decoder:
one for a valid value,
one for a invalid value,
and one to catch the encoder setter warning.

Here are the valid values:
https://ffmpeg.org/doxygen/6.0/qtrle_8c.html

@WyattBlue
Copy link
Member

I decided to throw an error instead of merely deprecating setting for encoders. I put my changes on the original PR #1203 and make changes to the docstring #1331 to fix the doc test.

@WyattBlue WyattBlue closed this Mar 12, 2024
@JoeSchiff
Copy link
Contributor Author

I'm confused as to what happened here. I'm concerned about not getting proper attribution as I don't see my name on my code here.

@WyattBlue
Copy link
Member

You are credited in 7a5c2d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants