Val dev merged reordered #219
Conversation
… into develop stay up to date
| -moz-user-select: none; /* Firefox */ | ||
| -ms-user-select: none; /* Internet Explorer/Edge */ | ||
| user-select: none; /* Non-prefixed version, currently supported by Chrome and Opera */ | ||
| } |
There was a problem hiding this comment.
@4xdk Do you see this used anywhere?
There was a problem hiding this comment.
Ah nice spot. I've used it on the menu but it went missing during refactoring I'll add it back to nav-pursuances!
| action='about' | ||
| icon={<Info size={28} />} | ||
| /> | ||
| <PursuanceMenuItem |
There was a problem hiding this comment.
@4xdk The latest version of this (in develop) is different; we no longer need to pass in pursuanceId and location explicitly, as PursuanceMenuItem is now reduxified.
| || | ||
| location.pathname.indexOf(`/${action}`) !== -1 | ||
| )) | ||
| ) |
There was a problem hiding this comment.
There is also more to this function now in develop; it treats the discuss action differently, which is what we want.
| font-weight: normal; | ||
| } | ||
|
|
||
| .custom-dropdown { |
There was a problem hiding this comment.
This dropdown doesn't seem to match the style of other dropdowns, but still looks good IMO.
As an aside, I couldn't find a way to navigate to pursuances/all normally.
|
I've updated to match site dropdown style, also changed to say 'sort' instead. |
| } | ||
|
|
||
| .custom-dropdown::before { | ||
| background-color: rgba(0,0,0,.15); | ||
| #dashboard .sort .dropdown.open > .dropdown-menu { |
There was a problem hiding this comment.
@4xdk Do you like using the > for efficiency? It makes things more brittle, but I don't know about the speed differences.
There was a problem hiding this comment.
TBH I just prefer to be reasonably specific to avoid styling something I didn't intend to. Especially working with unfamiliar code or overly generic classes as is the case here.
I wouldn't worry about CSS performance at all until we get to some serious animations.
Hopefully I didn't remove anything that was needed.
This is related to issues #122 and #123