Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode Uuid correctly (fixes #454) #583

Merged
merged 5 commits into from
Feb 23, 2025

Conversation

LooFifteen
Copy link
Contributor

Description

Fixes #454 by properly configuring uuid::Uuid serialization. This also removes the need for #[serde(with = "uuid::serde::compact")] across the codebase.

Testing

features.toml

[resource_pack]
enabled = true
url = "http://localhost:8080/resourcepack.zip"
sha1 = "abc123"
message = "test message"
force = true

Please follow our Coding Guidelines

@kralverde
Copy link
Contributor

Ah leave the is_human_readable set to false though

@kralverde kralverde merged commit 160d98d into Pumpkin-MC:master Feb 23, 2025
10 checks passed
@LooFifteen LooFifteen deleted the fix/uuid branch February 24, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource packs broken
2 participants