Skip to content

Warn devs from changing relied upon error message #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vicsn wants to merge 1 commit into from
Closed

Warn devs from changing relied upon error message #2929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion synthesizer/src/vm/verify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ impl<N: Network, C: ConsensusStorage<N>> VM<N, C> {
let result = match verification {
Ok(()) => match self.block_store().contains_state_root(&fee.global_state_root()) {
Ok(true) => Ok(()),
Ok(false) => bail!("Fee verification failed: global state root not found"),
Ok(false) => bail!("Fee verification failed: global state root not found"), // NOTE: review dependent codebases for this error message before changing it.
Err(error) => bail!("Fee verification failed: {error}"),
},
Err(error) => bail!("Fee verification failed: {error}"),
Expand Down