[Feat] Consensus-restricted keywords.#2685
Conversation
|
@reviewers I'm not too happy with the name |
|
|
vicsn
left a comment
There was a problem hiding this comment.
LGTM! Left two style suggestions.
synthesizer CI is failing when run with the --test feature because test_migration_v3_maximum_validator_increase assumes max validator set increases at consensus v3, whereas with the test feature enabled the max validator set is static at 100.
In other words, our usage of the test feature is a bit of an undocumented mess.
As a "quickfix", one option would be to use the same sample_finalize_state approach as in test_migration_v3_maximum_validator_increase, and then we can also get rid of introducing yet another CI job.
I had mapped the concept of "reserved" keywords to the |
If it's not too costly, it might be nice to have a CI run with the |
niklaslong
left a comment
There was a problem hiding this comment.
LGTM overall, pending the changes requested by other reviewers.
Motivation
As programming standards evolve on Aleo, it would be useful to be able to enforce syntactic restrictions at the consensus layer. This PR:
check_transactions.testfeature enabled for thesynthesizercrate.Test Plan
A test was added verifying that syntax restrictions are not enforced before a given version height and that they are enforced after.