Removes PartialEq and Eq on Map V traits#2669
Merged
vicsn merged 1 commit intofeat/improve-tree-logicfrom Apr 8, 2025
Merged
Conversation
raychu86
approved these changes
Mar 31, 2025
Collaborator
raychu86
left a comment
raychu86
left a comment
There was a problem hiding this comment.
LGTM. I did a check and there doesn't seem to be any case were we do comparisons directly on the maps (nor would we want to).
niklaslong
approved these changes
Apr 1, 2025
Collaborator
niklaslong
left a comment
niklaslong
left a comment
There was a problem hiding this comment.
In principle, this change should be fine. One caveat is if we ever have a requirement to compare maps in tests, though there are workarounds like re-implementing the trait (only for tests) or relying on the implementations of the test values. LGTM 👍
ljedrz
approved these changes
Apr 6, 2025
Collaborator
|
The failing CI is related to the base branch - merging because its going into a feature branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes
PartialEqandEqon MapVtraits.These properties are not needed, and reduces the dependencies required for an object to be supported by our maps.