[Feat] Introduce a persistent validator cache#3887
Merged
vicsn merged 3 commits intoProvableHQ:stagingfrom Sep 26, 2025
Merged
Conversation
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
ljedrz
force-pushed
the
feat/validator_peer_cache
branch
from
5587172 to
de6456e
Compare
vicsn
reviewed
Sep 25, 2025
vicsn
reviewed
Sep 25, 2025
vicsn
reviewed
Sep 25, 2025
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Collaborator
|
Can you confirm the tests you ran in the PR deacription |
Collaborator
Author
|
@vicsn done; I applied more or less the same treatment as with the |
vicsn
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a persistent validator cache, similarly to #3820.
As a drive-by, there is also a reduction of
Arcs within theGateway, which will reduce the number of atomic operations on each clone and drop by 7. This also makes it harder to misuse the newPeerPoolHandlingtrait by making separating the peer pool from theGatewayimpossible (CC #3879).Note: the associated issue states that
I'm assuming this means that we can't have two connected
GatewayPeers that have the same Aleo address. This, however, would be a more general change, as it would also affect the way the peer lists should be handled.I've tested it locally on new validators and after a restart - both
cached_router_peersandcached_gateway_peersfiles are created and processed, and the addresses are the ones I expected. Manually altering them confirmed that the cache would work for other (non-dev) addresses too.Closes #3869.