Propagate transactions even if global state root not found#3867
Merged
Propagate transactions even if global state root not found#3867
Conversation
raychu86
reviewed
Sep 18, 2025
vicsn
force-pushed
the
improve_propagation
branch
from
27bcc58 to
fa0c3cb
Compare
raychu86
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While combing through mainnet logs, I noticed a non-trivial amount (1000 per client per hour) of "global state root not found" errors. In all likelihood, these are caused by nodes temporarily being behind. This PR should improve the network's UX by letting those transactions propagate anyway.
Analysis
The performance impact under honest conditions should not be too bad, but may be offset by #3493
An attacker will have a somewhat easier time to get their transactions propagated to cause load on the network, but if they do so with an intentionally invalid state root, it will actually become cheaper for validators to reject it.
Because we don't use custom error types, we risk changing the underlying error message. So this should help: ProvableHQ/snarkVM#2929
Test Plan
Existing tests should suffice