[Refactor] More high-level network cleanups#3754
Merged
vicsn merged 10 commits intoProvableHQ:stagingfrom Aug 5, 2025
Merged
Conversation
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Collaborator
Author
|
One test has failed, looking into it 🕵️. All good now 👌. |
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
kaimast
requested changes
Jul 26, 2025
Contributor
kaimast
left a comment
kaimast
left a comment
There was a problem hiding this comment.
Just a few minor comments. Looks great!
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
kaimast
reviewed
Jul 29, 2025
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
kaimast
approved these changes
Aug 4, 2025
Contributor
|
Looks great now. I had one minor bit but we can also merge as it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a direct follow-up to #3713, continuing with a refactoring sweep of the higher-level network layer around the
Router.A summary of the changes:
RADIO_SILENCE_IN_SECSis renamed toMAX_RADIO_SILENCE_SECSPeerobject with atrustedflagheartbeatandoutboundmethods are refactored for brevity and improved performanceRoutermethods are removedNote: I currently only removed the updates to the
RESTRICTEDmetric; should the metric be removed altogether, or perhaps show the number of banned peers instead?