Skip to content

Simplify Storage::rounds map.#3602

Merged
kaimast merged 1 commit intoProvableHQ:stagingfrom
acoglio:storage-id-simp
May 20, 2025
Merged

Simplify Storage::rounds map.#3602
kaimast merged 1 commit intoProvableHQ:stagingfrom
acoglio:storage-id-simp

Conversation

@acoglio
Copy link
Contributor

@acoglio acoglio commented Apr 21, 2025

Since certificate ID and batch ID are always the same, we can simplify this map to avoid having two identical IDs, and having just one instead.

Since certificate ID and batch ID are always the same, we can simplify this map
to avoid having two identical IDs, and having just one instead.
@acoglio acoglio requested review from kaimast and raychu86 April 21, 2025 12:51
Copy link
Collaborator

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fairly straightforward.

Might be worth checking if any of our documentation (inside or outside snarkOS) that considers batch_id and certificate_id different or separate things.

@kaimast
Copy link
Contributor

kaimast commented May 20, 2025

Might be worth checking if any of our documentation (inside or outside snarkOS) that considers batch_id and certificate_id different or separate things.

It looks like both BatchCertificate::id and BatchCertificate::batch_id call self.batch_header.batch_id(). We should probably remove or deprecate one of th two.

@kaimast kaimast merged commit b20c3c7 into ProvableHQ:staging May 20, 2025
2 checks passed
@acoglio acoglio deleted the storage-id-simp branch May 21, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants