Add tests for checking incoming certificates#3560
Merged
kaimast merged 2 commits intoProvableHQ:stagingfrom May 21, 2025
Merged
Add tests for checking incoming certificates#3560kaimast merged 2 commits intoProvableHQ:stagingfrom
kaimast merged 2 commits intoProvableHQ:stagingfrom
Conversation
Collaborator
|
This can be rebased and opened! |
Contributor
Author
|
I rebased the PR on most recent staging and updated the snarkVM dependency. Should be ready to be merged now. |
acoglio
reviewed
Apr 9, 2025
acoglio
reviewed
Apr 9, 2025
acoglio
reviewed
Apr 9, 2025
acoglio
reviewed
Apr 9, 2025
acoglio
previously approved these changes
Apr 9, 2025
Contributor
acoglio
left a comment
acoglio
left a comment
There was a problem hiding this comment.
Looks good, just left a few (all related) comments.
kaimast
force-pushed
the
fix-cert-fetch
branch
2 times, most recently
from
515c250 to
e802cfa
Compare
Contributor
Author
|
I rebased this PR to the most recent staging and addressed the remaining comments. @acoglio could you take another look? |
acoglio
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests for
check_incoming_certificate(added in PR #3537) andcheck_certificate.Depends on SnarkVM PR #2665.