feat: Add support for both ip and hostname for peers by Raphexion · Pull Request #3432 · ProvableHQ/snarkOS

Raphexion · 2024-11-08T14:49:17Z

Motivation

It is convinent to be able to specify both IPs and hostnames as peers. Especially, when you are building ephemeral testnets and want to specify peers as

./snarkos start --peers "validator0:4130,client0:4130"

Where you can populate the /etc/hosts file with subnet hostnames.

Test Plan

Added unit-tests but can be tested on the commandline

Related PRs

None.

cli/src/commands/start.rs

ljedrz

LGTM 👌

vicsn · 2024-11-11T15:09:16Z

cli/src/commands/start.rs

+                    let trimmed = ip_or_hostname.trim();
+                    match trimmed.to_socket_addrs() {
+                        Ok(mut ip_iter) => {
+                            // A hostname might resolve to multiple IP addresses. We will use only the first one,


To avoid any surprises for node operators, is there any known syntax for selecting a particular index? Should we invent our own, e.g. hostname:port:1

An alternative solution would be to enforce that only one IP is expected and allowed. So if there are more than one IP found, then we will print a warning and ignore the hostname.

The main idea behind this feature is to allow for a more flexible setup during tests. And in those cases, we can make sure that there is only one "validator-1" and only one "client-42". So I think it is a good trade-off, to enforce that only one IP is expected and found.

vicsn · 2024-11-11T15:16:05Z

Though its a small and useful change, let's make sure there's buy-in and awareness from all dev orgs that the nodes now also rely on DNS, incurring a small new privacy and security risk.

Also worth looking at geth's recent addition, which apparently also picks the first ip if multiple are defined. :) ethereum/go-ethereum#18524

Raphexion · 2024-11-12T07:47:10Z

@vicsn I agree 💯 , we should make sure that this feature is wanted and accepted 👍

And great link to geth 🙏 ☀️

It is convinent to be able to specify both IPs and hostnames as peers. Especially, when you are building ephemeral testnets and want to specify peers as ``` ./snarkos start --peers "validator0:4130,client0:4130" ``` Where you can populate the `/etc/hosts` file with subnet hostnames.

Raphexion force-pushed the nijo/add-support-for-hostname-peers branch from 21a4598 to eee4dc7 Compare November 8, 2024 15:11