Fix a source of the 'Unknown API error.' #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since November 2020 the parameter 'strict' was removed from urllib3 HTTPSConnectionPool and HTTPConnectionPool classes' init in connectionpool.py. Leaving the parameter 'strict' in the call is shifting the next ones and timeout is taken as a boolean leading to the error 'Timeout cannot be a boolean, it must be an...' raising an UnknownConnectionError in api.py and finally the famous UnknowAPIError in the cli_wrapper.py. This explains why so many people have their proton cli not working after updating their packages with urllib3 among them.
|
Can confirm this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello dear Proton team and community,
Since November 2020 the parameter
strictwas removed from urllib3 forHTTPSConnectionPoolclass in connectionpool.py. Leaving the parameterstrictin the call is shifting the next ones andtimeoutis taken as a boolean leading to the error'Timeout cannot be a boolean, it must be an...'raising anUnknownConnectionErrorin api.py and finally the famousUnknownAPIErrorin the cli_wrapper.py.This explains why so many people on forums have their proton cli not working after updating their packages with urllib3 among them.