Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golint vet errcheck on ProtonMail fork #32

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Golint vet errcheck on ProtonMail fork #32

wants to merge 15 commits into from

Conversation

zugzwang
Copy link
Contributor

@zugzwang zugzwang commented Aug 29, 2019 •
edited
Loading

This branch contains a better linted crypto package with golint, vet, errcheck, deadcode, etc.

  • Export functions, variables, methods, properties with initialisms are not corrected in order to preserve the API.
  • Add or correct comments globally.
  • Fix some shadowed declarations, missing or ghost error checks.

@zugzwang zugzwang mentioned this pull request Aug 29, 2019
Closed
Lint, errcheck, vet, deadcode on ProtonMail-provided code.
12366c5 
Halfway through

Halfway through

Finished first pass

Solving tests.

Relaxing a bit on useless comments, but frowning.

Fix comment

Linted openpgp/packet, at least some of it

Reverting ID -> Id

Reverting Fingerprint -> FingerPrint

Solving tests

Relaxing on some useless comment and reverting Fingerprint -> FingerPrint

Missing parenthesis

Corrected exported object comments globally
@zugzwang zugzwang force-pushed the golint-vet-errcheck-protonmail-fork branch from 66d0d73 to 12366c5 Compare August 30, 2019 10:27
twiss
twiss reviewed Nov 1, 2019
View reviewed changes
openpgp/clearsign/clearsign.go Outdated Show resolved Hide resolved
openpgp/end_to_end_test.go Outdated Show resolved Hide resolved
openpgp/packet/signature.go Outdated Show resolved Hide resolved
openpgp/internal/algorithm/cipher.go Outdated Show resolved Hide resolved
openpgp/packet/signature.go Outdated Show resolved Hide resolved
zugzwang and others added 14 commits November 1, 2019 19:57
openpgp: Repaired some shadowed errors, discovered inactive test that…
f3b8034 
… does not pass
Fixed some shadowed declarations and err checking
263b967
@zugzwang @twiss
Update openpgp/internal/algorithm/cipher.go
f0dec49 
Co-Authored-By: Daniel Huigens <[email protected]>
Reverting end-to-end-test in favor of ProtonMail#37 and addressing tw…
e4c9ff9 
…iss comments
Merge branch 'golint-vet-errcheck-protonmail-fork' of github.com:zugz…
1362900 
…wang/crypto into golint-vet-errcheck-protonmail-fork
Remove unnecesary conversion
dd35a8d
Small style improvements
1694ebe
Merge branch 'master' into golint-vet-errcheck-protonmail-fork
080235a
Solve conflicts
bb412a6
Remove function reference from bcrypt comments
e363b82
Remove non-PM comment correction
98fd4af
Remove non-PM comment corrections
a0b2e01
Remove non-PM comment corrections
42e6669
Merge branch 'master' into golint-vet-errcheck-protonmail-fork
fe63ad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiss twiss twiss left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zugzwang @twiss