[v2] Check signature details of binding signatures #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the hash algorithm, creation time, signature notations, and signature expiry (when relevant) of binding signatures when using keys. To be able to check that all critical signature notations are known, we add `config` parameters to all functions on the path to verifying key binding signatures in v2.
lubux
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Great work 👍 Before merging we should check that there are no regressions in the interoperability test-suite. To fix the CI, we could just update the gopenpgp commit hash here in this branch.
Co-authored-by: Lukas Burkhalter <[email protected]>
lubux
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the hash algorithm, creation time, signature notations, and signature expiry (when relevant) of binding signatures when using keys.
To be able to check that all critical signature notations are known, and the hash algorithm used is valid, we add
configparameters to all functions on the path to verifying key binding signatures in v2.By default, we reject binding signatures using MD5 and RIPEMD-160, but this can be modified by setting the new
config.RejectHashAlgorithmsproperty. In the future, we should also reject binding signatures using SHA-1, but this would be a larger breaking change.