Sprint 58 minor changes #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev into master
Merge dev into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following minor changes:
Always display the AlphaFold track, even if it is the only track (IBU-11654)
Now we correctly display the track and the "No entry matches this protein banner". (e.g A0A009GMH1).
There are cases where the entries count is 0 but a Pfam-N match is found. If the user is in summary mode, that leads to a similar result, but without the "No entry" warning. Not sure if we should do anything about that. (e.g A0A009GL87)
Fix the job name given to InterProScan searches (IBU-11663, InterPro-search by sequence-Job title #683)
Now assigning a name to the job on submit works. Editing the name after the job has completed works too.
Link citations to references in Pfam clan descriptions (IBU-11661, Links to references in the descriptions in Pfam Clan pages #666)
Reusing the logic that links publications ID to citations in the Reference section for Entries and Proteins, we now do the same for Pfam clans using PMIDs. (e.g. CL0025)
There are cases (like in CL0025, citation nr. 1). Where a paper is listed in the references but never cited in the description.
Numeric ECOD not being displayed in Wikipedia infobox for clans (IBU-11680 , Wikipedia in Pfam clan pages #694)
ECODs where being only processed as alphanumeric strings (e.g 389.1.1). There are cases where the ECOD is just a number (e.g CL0001) and it was not being displayed correctly. Now it is (e.g. CL0021)
Use the structure accession for matches in the structure page IBU-11681.
There are cases where a match is integrated in an InterPro entry, but they are mapped to different UniProt accessions. This caused a visualization issues on the ProteinViewer(s) in the structure page where the match is not seen as a child of the InterPro entry. Using the structure accession to keep them in the same data structure fixes this. (e.g. 5cgc)
