Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptGen in subpages + Search propagated to ScriptGen + Homepage browsing by tab changes #671

Merged
merged 4 commits into from
Nov 4, 2024
Merged

ScriptGen in subpages + Search propagated to ScriptGen + Homepage browsing by tab changes #671

merged 4 commits into from
Nov 4, 2024

Conversation

apolignano
Copy link
Contributor

This PR addresses the minor changes requested in:

@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Coverage Status

coverage: 18.573% (-0.2%) from 18.8%
when pulling 0085956 on min_changes_sprint_54
into fb3bbe6 on dev.

matthiasblum
matthiasblum requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small inconsistency in the "Species" tab that needs to be addressed. Everything else looks good.

matthiasblum
matthiasblum approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge. Thanks.

@matthiasblum matthiasblum merged commit 4617421 into dev Nov 4, 2024
3 checks passed
@matthiasblum matthiasblum deleted the min_changes_sprint_54 branch November 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblum matthiasblum matthiasblum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apolignano @coveralls @matthiasblum