fix PMKAlamofire imports compatibility with CocoaPods #52
Conversation
Sources/Alamofire+Promise.swift
Outdated
| @@ -1,6 +1,6 @@ | |||
| @_exported import Alamofire | |||
There was a problem hiding this comment.
Hello @VaryHice
Are you sure we cannot resolve it without @_exported?
There was a problem hiding this comment.
To solve compilation issue import without @_exported fits as well, should I remove it?
There was a problem hiding this comment.
@VaryHice Yes. Is it possible?
There was a problem hiding this comment.
@RomanPodymov sure, updated code
There was a problem hiding this comment.
@VaryHice Thanks, will check this on my side, if it works, then we can merge your solution.
There was a problem hiding this comment.
@RomanPodymov sorry to bother, but any luck we could proceed? I'm ready to continue and bring back Alamofire subspec to PromiseKit, but this issue is a blocker
There was a problem hiding this comment.
Hello @VaryHice
As I can see Alamofire has been removed from podspec because of iOS 10 or 11 deployment target, but let me check if we can revert it.
There was a problem hiding this comment.
Hello @VaryHice
Looks like I cannot install PMKAlamofire with CocoaPods. Can you please tell me, which PMKAlamofire version are you using?
There was a problem hiding this comment.
Hello @RomanPodymov
My fork was based on tag 5.0.1. Currently I use it in my project and can successfully install with CocoaPods 1.16.2.
Can't compile project with PMKAlamofire installed with CocoaPods due to recent changes in imports section. This PR restores previous state as it was in PMKAlamofire v5.0.0.
Upd: modified import to remove export