Added support for HTTPS Pushgateway endpoints

[andremv]

This solves the issue with the Pushgateway endpoint being hardcoded to a http endpoint.

1) Test\BlackBoxPushGatewayTest::pushGatewayShouldWork
GuzzleHttp\Exception\ClientException: Client error: `PUT http://super-secure-pushgateway:443/metrics/job/my_job/instance/foo` resulted in a `400 Bad Request` response:
(truncated...)

I also brought over the missing php-fpm directory from PromPHP/prometheus_client_php repo.

[LKaemmerling]

Hey @andremv,

first of all, Thank you! Good idea and a good catch. I have two smaller "issues" that should be addressed. The biggest "issue" in my mind is the miss of unit tests for the current & new behavior. We need to make sure that we don't introduce a breaking change.

[LKaemmerling]

Hey @andremv,

thank you! I have just one small note (the doc string on the doRequest method), otherwise, it looks fine from my side. An please have a look at the DCO test: https://github.com/PromPHP/prometheus_push_gateway_php/pull/2/checks?check_run_id=1283429563

Maybe @rdohms, if you have time could you also have a fix look?

[LKaemmerling]

LGTM thank you!

[andremv]

It was my pleasure @LKaemmerling! And thank you for maintaining this library.

[rdohms]

Looks great, minor nitpick on readability.

Consideration for @LKaemmerling since we have not talked about it. My team's usual approach is to rebase and make fixes directly on the commit that introduced the code instead of adding new fix commits. Thoughts?

[LKaemmerling]

Looks great, minor nitpick on readability.

Consideration for @LKaemmerling since we have not talked about it. My team's usual approach is to rebase and make fixes directly on the commit that introduced the code instead of adding new fix commits. Thoughts?

@rdohms yep I like that too, in most MRs I use squashing so that in the end it doesn’t matter how many commit were in the branch.

@andremv your welcome!

[LKaemmerling]

Thank you!