-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learned how to wipe the storage adapter from the registry #89
Conversation
Hey @pachico, good idea! I like it. Could you please rebase from main and sign your commit? (DCO check)? |
Not entirely sure what I'm supposed to do but I'll try :) |
In the meanwhile, do you see anything that should be amended in the code changes? |
@pachico For the DCO stuff: https://github.com/PromPHP/prometheus_client_php/pull/89/checks?check_run_id=5881792022 The think the code and the test is fine :) |
Signed-off-by: Mariano Benítez Mulet <[email protected]>
Got it, thanks, @LKaemmerling , I think now is all set. |
Head branch was pushed to by a user without write access
Hey @pachico, there is only one small test red :) Can you fix it? I would then consider releasing this asap :) |
Signed-off-by: Mariano Benítez Mulet <[email protected]>
On its way! @LKaemmerling thanks for your patience! |
It seems it finally all went through :) Thanks again @LKaemmerling |
Good job! Thanks! |
Thanks a lot, @LKaemmerling ! |
This addresses issue #88 by allowing to wipe the underlying storage adapter from the registry itself.