Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learned how to wipe the storage adapter from the registry #89

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

pachico
Copy link
Contributor

@pachico pachico commented Apr 8, 2022

This addresses issue #88 by allowing to wipe the underlying storage adapter from the registry itself.

@LKaemmerling
Copy link
Member

Hey @pachico,

good idea! I like it. Could you please rebase from main and sign your commit? (DCO check)?

@pachico
Copy link
Contributor Author

pachico commented Apr 11, 2022

Not entirely sure what I'm supposed to do but I'll try :)

@pachico
Copy link
Contributor Author

pachico commented Apr 11, 2022

In the meanwhile, do you see anything that should be amended in the code changes?
Is that test enough? (I think it is but I want to make sure.)

@LKaemmerling
Copy link
Member

@pachico For the DCO stuff: https://github.com/PromPHP/prometheus_client_php/pull/89/checks?check_run_id=5881792022

The think the code and the test is fine :)

@pachico
Copy link
Contributor Author

pachico commented Apr 12, 2022

Got it, thanks, @LKaemmerling , I think now is all set.
Do you have any release/tag planning we could count on? I'd really like to work with your repo rather than with a fork :)

@LKaemmerling LKaemmerling enabled auto-merge (squash) April 12, 2022 07:01
auto-merge was automatically disabled April 12, 2022 07:28

Head branch was pushed to by a user without write access

@LKaemmerling
Copy link
Member

Hey @pachico,

there is only one small test red :) Can you fix it? I would then consider releasing this asap :)

@pachico
Copy link
Contributor Author

pachico commented Apr 12, 2022

On its way! @LKaemmerling thanks for your patience!

@pachico
Copy link
Contributor Author

pachico commented Apr 12, 2022

It seems it finally all went through :) Thanks again @LKaemmerling

@LKaemmerling LKaemmerling merged commit 1088114 into PromPHP:main Apr 12, 2022
@LKaemmerling
Copy link
Member

Good job! Thanks!

@pachico
Copy link
Contributor Author

pachico commented Apr 12, 2022

Thanks a lot, @LKaemmerling !
I'm already using it!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants