Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Proof of concept how to include openmetric exemplars. #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hrodic
Copy link

@hrodic hrodic commented May 3, 2021

No description provided.

@hrodic
Copy link
Author

hrodic commented May 3, 2021

This is just and idea on how the rendering should be and how the usage could be.

There seems to be coupling with the storage drivers.

To add exemplars in histogram, it needs to ensure that only one exemplar is added per bucket.

Starting by adding public API proposal + Exporter Text format expected output functional test.

@hrodic hrodic force-pushed the openmetric-exemplar-support branch from d9c5cb7 to 91851b4 Compare May 3, 2021 13:59
@LKaemmerling
Copy link
Member

Hey @hrodic,

thank you! This proposal looks fine for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants