Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicize symfony bundle integration #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbouzekri
Copy link

I made an integration of you library in the framework Symfony. Can you publicize it on your readme ? Thanks in advance

Signed-off-by: Jonathan Bouzekri <[email protected]>
Copy link
Member

@rdohms rdohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest we add it to the composer.json suggests block instead. But If we want to endorse this I need to do some checking on what's out there first.

@jbouzekri
Copy link
Author

No problem. I am waiting for your feedback.

@LKaemmerling
Copy link
Member

I personally don't think we should start adding things that implement the client/sdk because it will be unfair for others and in the end, the list might be really big. I would prefer to publish an "own"/"official" symfony bundle/laravel package and so on, but this is with our currently given manpower not possible.

@rdohms @nickpoulos what do you think?

@nickpoulos
Copy link
Member

I tend to agree with you here @LKaemmerling. It would be nice to have an 'official' Symfony and Laravel integration packages this way there are not 10 diff versions. But I am not against this PR being the starting path towards something like that, like you said we don't quite have the manpower yet but with some help like this we could get there faster.

I have to kind of look at what this really means in practice though. For instance we are using this package in a Laravel project right now, so besides registering a little service provider/facade, extra config...not sure what else we would want to see.

@simPod
Copy link
Contributor

simPod commented Aug 8, 2021

IMO people should use packagist.org to search for a things like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants