fix for APCng prometheus storage - very high ttl for metrics entries #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll with apcu entry expiration algorithm when low global ttl is set, entry ttl needs to be very high Signed-off-by: Rastusik <[email protected]>
Rastusik
force-pushed
the
apcng_ttl_fix
branch
from
fca5506
to
018a336
Compare
LKaemmerling
requested changes
Dec 6, 2023
| * | ||
| * @throws StorageException | ||
| */ | ||
| public function __construct(string $prometheusPrefix = self::PROMETHEUS_PREFIX, int $decimalPrecision = 3) | ||
| public function __construct(string $prometheusPrefix = self::PROMETHEUS_PREFIX, int $ttl = 10368000, int $decimalPrecision = 3) |
There was a problem hiding this comment.
Please move this at the end, as it would be a breaking change otherwise.
xocasdashdash
added a commit
to PaddleHQ/prometheus_client_php
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero ttl for metrics entries does not work well on deployments with low global apcu.ttl value, metrics data are expiring randomly. so by default, all metrics values have a (configurable) ttl which is very high - 120 days