Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let manifesto mutate the manifest json. #4036

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Don't let manifesto mutate the manifest json. #4036

merged 2 commits into from
Dec 13, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 12, 2024

This is the other part of #4016. manifesto's been mutating the provided manifest to add its data structures. This isn't a big problem for normal manifests, but the collection representation has a cyclic reference.

marlo-longley
marlo-longley previously approved these changes Dec 12, 2024
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works locally for me.

My only suggestion is to add a comment otherwise this could be a tad cryptic.
Something like ... "Use JSON stringify/parse to create a deep copy and prevent Manifesto from mutating the json" ?

@cbeer cbeer merged commit d105e6b into master Dec 13, 2024
8 checks passed
@cbeer cbeer deleted the manifesto branch December 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants