-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace withTranslation HOC with hooks and test against actual i18n'd values #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16a5e3b
to
eccc503
Compare
This is awesome so much cleaner, thank you Chris !!
|
eccc503
to
5079b84
Compare
Yes, I think those are the next steps, and I'm hopeful this'll merge nicely into the vite branch (and if it doesn't, it should just be removing lines of code...) |
ce98664
to
3be0e1e
Compare
Needs rebase but looks good to me. |
26ede06
to
7124e2a
Compare
7124e2a
to
4199d2c
Compare
marlo-longley
previously approved these changes
Dec 10, 2024
cf28d6e
to
6d08078
Compare
6d08078
to
bb3cbda
Compare
marlo-longley
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.