Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hold space for companion windows if there aren't any. #3867

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 18, 2023

Before:
Screenshot 2023-12-18 at 10 31 22

After:
Screenshot 2023-12-18 at 10 31 38

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a08aa6a) 92.50% compared to head (2514469) 92.50%.
Report is 14 commits behind head on mui5.

Files Patch % Lines
src/components/ScrollIndicatedDialogContent.js 50.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             mui5    #3867      +/-   ##
==========================================
- Coverage   92.50%   92.50%   -0.01%     
==========================================
  Files         203      203              
  Lines        3576     3575       -1     
==========================================
- Hits         3308     3307       -1     
  Misses        268      268              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcoyne jcoyne merged commit ec6b764 into mui5 Dec 18, 2023
@jcoyne jcoyne deleted the companion-window-size branch December 18, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants