Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests when making PRs against the mui5 branch #3794

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Oct 26, 2023

This will allow us to make PRs to the mui5 branch and see that we are chipping away at tests passing
Right now if I PR against mui5 with my changes to the tests, CI does not run.
We can delete this after the mui5 branch is merged; not sure if there is a cleaner way to do it. I would rather not push directly to that branch as it is already huge.
Thanks!

@marlo-longley marlo-longley marked this pull request as ready for review October 26, 2023 22:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #3794 (93c466a) into master (5a95d44) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #3794   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files         201      201           
  Lines        3465     3465           
=======================================
  Hits         3205     3205           
  Misses        260      260           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cbeer cbeer merged commit 7866f7e into ProjectMirador:master Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants