Fix MUI5 testing errors #3793
Merged
Fix MUI5 testing errors #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
mui5-tests
branch
2 times, most recently
from
b0df016 to
4a5bf0d
Compare
…wThumbnail component
marlo-longley
force-pushed
the
mui5-tests
branch
from
4a5bf0d to
00217bd
Compare
marlo-longley
changed the title
marlo-longley
force-pushed
the
mui5-tests
branch
from
f496927 to
52822b8
Compare
barmintor
approved these changes
Oct 28, 2023
| @@ -6,7 +6,8 @@ describe('Thumbnail navigation', () => { | |||
| await expect(page).toMatchElement('.mirador-window', { polling: 'mutation', timeout: 5000 }); | |||
| }); | |||
|
|
|||
| it('navigates a manifest using thumbnail navigation', async () => { | |||
| //TODO: pick a new url; this Harvard one is 404 | |||
There was a problem hiding this comment.
The manifest URL seems ok - is it required in Mirador for canvas IDs to be dereferenceable? It looks like that manifest has all the relevant canvas data inline.
| @@ -138,6 +138,7 @@ export class ManifestListItem extends Component { | |||
| }, | |||
| })} | |||
| data-manifestid={manifestId} | |||
| data-active={active} | |||
There was a problem hiding this comment.
I wonder if the best way to handle this in mui5 is to make this a ListItemButton and use the selected attribute (which deprecated on ListItem but not ListItemButton).
marlo-longley
force-pushed
the
mui5-tests
branch
from
e27a3ce to
8932afd
Compare
|
Because of a migration, I had to add mui-x to our project to keep using Tree View: It is a paid product but is also free to use under MIT License, so I think we should. be good. But wanted to check on that. |
|
@marlo-longley I came to the same conclusion for the React18 patches on our fork. |
phil-plencner-hl
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.