#2287: replace selection list by simple list for change theme dialog

[glefi]

Closes #2287

[codecov-io]

Codecov Report

Merging #2338 into master will decrease coverage by 0.09%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master    #2338     +/-   ##
=========================================
- Coverage   91.45%   91.35%   -0.1%     
=========================================
  Files         103      106      +3     
  Lines        1392     1446     +54     
=========================================
+ Hits         1273     1321     +48     
- Misses        119      125      +6

Impacted Files	Coverage Δ
src/components/WorkspaceMenu.js	83.33% <0%> (ø)	⬆️
src/lib/KeyHelper.js	100% <100%> (ø)
src/components/ChangeThemeDialog.js	66.66% <66.66%> (ø)
src/components/WorkspaceSelectionDialog.js	90% <80%> (-10%)	⬇️
src/lib/ListKeyboardNavigation.js	94.87% <94.87%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636d712...d540545. Read the comment docs.

[ggeisler]

@glefi Nice start on this. I'm not sure if this PR is intended to be complete or a work-in-progress but here are a couple of minor issues that should be updated, in case you are not already aware of them:

• The title heading for the dialog window should use Headline 2 typography defined in Typography classes & styles #2093, rather than the H6 it currently uses. (This was noted in the dialog story ticket.)

Some things that don't match the component demo at https://material-ui.com/demos/dialogs/#simple-dialogs but should:

• Hover highlighting as you move over the different theme options
• Cursor should be the hand cursor when highlighting any part of the theme options; currently it shows a pointer cursor when hovering over the icon and changes to a selection cursor when hovering over the theme option text
• The dialog should close automatically when selecting an option; currently the theme changes when selecting an option but the dialog doesn't close until you click again

Also, the dialog doesn't seem accessible via keyboard?

[glefi]

@ggeisler Thanks for your feedback. The dialog should now meet all the requirements. It would be nice if you could take another look at it.

[ggeisler]

Yep, the Change theme dialog looks good to me.

[camillevilla]

Looks good to me, @glefi!

I did notice some stuff for the Select Workspace Type dialog ticket #2288 in here as well. I wasn't sure if that was a prerequisite for #2287 (which I see you're also assigned to), but I'm definitely not complaining about more cats in Mirador...

I'm approving this PR for now. Feel free to merge it yourself when you see this!

[ggeisler]

Just to be clear, my comments above on this PR were for only the Change theme dialog, not the Select workspace type dialog.

@glefi I assume you know that the Change workspace type dialog still needs:

• Adding the SVG icons I pointed you to
• Showing highlighting for the currently active workspace type

The latter issue does work in the Change theme dialog but last I saw when you open the Change workspace type dialog it does not show any highlighted for the currently selected type.