Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typography; fixes #2093 #2102

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Update typography; fixes #2093 #2102

merged 3 commits into from
Mar 8, 2019

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Mar 8, 2019

I've tried to reconcile the table in #2093 with the theme defaults in https://material-ui.com/customization/default-theme/, and only adding the difference to our theme. Hopefully I translated everything correctly...

@codecov-io
Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #2102 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2102      +/-   ##
==========================================
- Coverage   94.36%   94.04%   -0.32%     
==========================================
  Files          81       81              
  Lines         923     1042     +119     
==========================================
+ Hits          871      980     +109     
- Misses         52       62      +10
Impacted Files Coverage Δ
src/components/WindowSideBarInfoPanel.js 100% <ø> (ø) ⬆️
src/components/LabelValueMetadata.js 100% <ø> (ø) ⬆️
src/components/WindowTopBar.js 80% <ø> (ø) ⬆️
src/components/WorkspaceMenuButton.js 90% <0%> (-1.67%) ⬇️
src/state/actions/window.js 68.96% <0%> (-1.63%) ⬇️
src/components/WorkspaceMenu.js 85.96% <0%> (-0.25%) ⬇️
src/components/ThumbnailNavigation.js 96.8% <0%> (-0.02%) ⬇️
src/components/CompanionArea.js 100% <0%> (ø) ⬆️
src/components/NestedMenu.js 100% <0%> (ø) ⬆️
src/components/CompanionWindow.js 100% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dfdc4...dcf945a. Read the comment docs.

@jkeck jkeck requested a review from jvine March 8, 2019 20:12
Copy link
Member

@jkeck jkeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these are copypasta typos or intended. Would also like @jvine to take a look a the Netlify deploy to 👍 it

src/config/settings.js Outdated Show resolved Hide resolved
src/config/settings.js Outdated Show resolved Hide resolved
Co-Authored-By: cbeer <[email protected]>
@jvine
Copy link
Collaborator

jvine commented Mar 8, 2019

One problem from a (now fixed) typo in my table:

Button should have letter-spacing of 0.09em (not 0.9em).

No
Screen Shot 2019-03-08 at 12 29 05 PM

Yes
Screen Shot 2019-03-08 at 12 28 52 PM

src/config/settings.js Outdated Show resolved Hide resolved
src/config/settings.js Outdated Show resolved Hide resolved
@aeschylus
Copy link
Collaborator

Looks great at the demo link.

@aeschylus aeschylus merged commit 2591b42 into master Mar 8, 2019
@camillevilla camillevilla deleted the 2093-typography branch March 8, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants