Skip to content

Remove “(Added from URL)” string from catalog items #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
ggeisler opened this issue Sep 28, 2020 · 0 comments · Fixed by #3448
Closed
2 tasks

Remove “(Added from URL)” string from catalog items #3270

ggeisler opened this issue Sep 28, 2020 · 0 comments · Fixed by #3448
Assignees

Comments

@ggeisler
Copy link
Collaborator

We currently display a “(Added from URL)” message for catalog items that the user adds to the workspace, either by using the Add Resource button to add an item via a manifest URL, or by navigating within a collection object and opening an item.

We do want to distinguish the default, configured workspace items from items added by the user, but the currently implementation has a couple of problems:

  • In addition to the two means noted above by which the user can add items to the workspace, we currently display the “(Added from URL)” message for items that are part of the workspace configuration but happen to be the items configured to display in workspace windows. For example, in the screenshot below, the first two items in the catalog show the “Added from URL” message, but are in fact part of the initial configured workspace just like all the other items are.

  • When we display the “(Added from URL)” message, it obscures the institution name for that item.

Screen Shot 2020-09-28 at 1 49 03 PM

Recommended fixes:

  • Treat all items that are part of the initial workspace configuration the same, which means none are “user-added.”

I can’t think of a reason why the user would need to keep track of which items were initially displayed in workspace windows versus those that are part of the workspace but not initially displayed in windows. (Even when closed, those items are available in the catalog, and I think might always be displayed at the top of the catalog, aside from any user-added items.)

  • Don't display the "(Added from URL)" text for any items, but ensure we can distinguish truly user-added items from initially configured items.

Rather than using the “(Added from URL)” message, I have another suggestion that I will post in a separate ticket. For purposes of this ticket, I think the action is simply to omit the “(Added from URL)” message but ensure we can distinguish user-added items as we currently do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants