Don't construct new objects in selector inputs

ProjectMirador · Dec 20, 2023 · df8f56f · df8f56f
1 parent d6e71d6
commit df8f56f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/state/selectors/companionWindows.js b/src/state/selectors/companionWindows.js
@@ -98,9 +98,9 @@ const getCompanionWindowIdsOfWindow = createSelector(
 export const getCompanionWindowsForPosition = createSelector(
   [
     getCompanionWindowsOfWindow,
-    (state, { position }) => ({ position }),
+    (state, { position }) => (position),
   ],
-  (companionWindows, { position }) => companionWindows[position] || EMPTY_ARRAY,
+  (companionWindows, position) => companionWindows[position] || EMPTY_ARRAY,
 );
 
 /**
@@ -113,9 +113,9 @@ export const getCompanionWindowsForPosition = createSelector(
 export const getCompanionWindowsForContent = createSelector(
   [
     getCompanionWindowsOfWindow,
-    (state, { content }) => ({ content }),
+    (state, { content }) => (content),
   ],
-  (companionWindows, { content }) => (
+  (companionWindows, content) => (
     [].concat(...Object.values(companionWindows)).filter(w => w.content === content)
   ),
 );
@@ -126,9 +126,9 @@ const EMPTY_ARRAY = [];
 export const getCompanionWindowIdsForPosition = createSelector(
   [
     getCompanionWindowIdsOfWindow,
-    (state, { position }) => ({ position }),
+    (state, { position }) => (position),
   ],
-  (companionWindowIds, { position }) => companionWindowIds[position] || EMPTY_ARRAY,
+  (companionWindowIds, position) => companionWindowIds[position] || EMPTY_ARRAY,
 );
 
 /**