Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove path and url node dependencies from main entry points #105

Merged
merged 2 commits into from
Jan 4, 2023
Merged

remove path and url node dependencies from main entry points #105

merged 2 commits into from
Jan 4, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 28, 2022 •
edited
Loading

Related Issue

related to #36

Summary of Changes

  1. Remove dependencies on Node specific path and url dependencies

TODO

  1. Clean up jsx-loader.js

Unfortunately it seems like fs might be here with us a bit per ProjectEvergreen/greenwood#953 (comment)

@thescientist13 thescientist13 added the feature New feature or request label Dec 28, 2022
@thescientist13 thescientist13 changed the title remove path dependency from main entry point remove path and url dependency from main entry points Dec 28, 2022
@thescientist13 thescientist13 changed the title remove path and url dependency from main entry points remove path and url node dependencies from main entry points Dec 28, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 28, 2022
@thescientist13 thescientist13 added enhancement Improvement to existing functionality and removed feature New feature or request labels Jan 4, 2023
@thescientist13 thescientist13 marked this pull request as ready for review January 4, 2023 20:36
@thescientist13 thescientist13 force-pushed the feature/issue-36-remove-path-and-url-node-deps branch from 73b2d94 to 416a067 Compare January 4, 2023 20:39
@thescientist13 thescientist13 merged commit 5242b02 into master Jan 4, 2023
@thescientist13 thescientist13 deleted the feature/issue-36-remove-path-and-url-node-deps branch January 4, 2023 20:42
@thescientist13 thescientist13 linked an issue Jan 4, 2023 that may be closed by this pull request
Agnostic (Edge) Runtime support #36
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.7.0 enhancement Improvement to existing functionality
Projects
[WCC] General Activities
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Agnostic (Edge) Runtime support
1 participant
@thescientist13