Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/issue 763 parcel css bundling #977

Closed

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 4, 2022

Related Issue

#763

Summary of Changes

  1. Swapped out PostCSS with ParcelCSS in CLI package
  2. Updated PostCSS plugin and deps accordingly
  3. Ensure Style bundling includes interception

As for making our own CSS bundler, we probably could, but maybe more of 2.0 thing?

Builds off #971. See here for the stacked diff.

TODO

  1. Update specs due to ParcelCSS "fixing" styles?
    -body{color:red}h1{color:#00f}
    +body{color:red}h1{color:blue}
  2. Update tech stack docs
  3. More specs failing in GitHub Actions than locally?
  4. Getting a 404 on nested CSS paths when deep link refreshing, e.g. /blog/releases/0.27.0 - seems that only the bundle method supports inlining @import, but it requires a file to seed the compiler. Which means we have to work on scratch files, but that loses the context of relative paths, which is something PostCSS Import had a solution for.
    • so there is a custom resolver, but it borks on non-relative URLs? (like google font URLs)
Screen Shot 2022-09-03 at 7 46 18 PM

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins CLI alpha.1 v0.27.0 labels Sep 4, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Sep 4, 2022
@thescientist13 thescientist13 self-assigned this Sep 4, 2022
@thescientist13 thescientist13 added this to IN PROGRESS in 8 - SSR Enhancements Sep 4, 2022
* add cloud IDE caveat to puppeteer renderer plugin readme (#967)

* init commit of refactoring for script tags with a src

* initial CSS optimizing

* sync optimized link tags in final output

* refactored for shared reources

* handle inline script bundling

* support serving custom resources using Greenwood plugins in Rollup configuration without needing extra rollup plugin

* non resource related Rollup plugins supported

* custom resource plugins and rollup plugins working together

* handle empty input for Rollup

* updated lock file

* handle inline style tag bundling and optimizing

* default optimization spec passing

* refactor merging app and page templates

* clarifying corrections in spec files

* inline optimization config working

* none optimization support

* none optimization support

* none and static optimization overrides

* refactor html rendering and optimizing

* refactoring and more CLI specs passing

* add missing variable

* SSR specs and optimizing resource bundling

* minor refactoring and logging

* resolving some plugin specs

* restore develop command related GraphQL specs

* custom graphql query spec

* all specs passing

* drop rollup plugin deps from import typescript plugin

* all Greenwood commands and specs passing

* restore static router with custom prerender

* restore postcss-import

* refactor shared resources to a Map and handle dupes

* restore local packages workaround for local Rollup bundling

* better monorepo Rollup facade modules detection

* switch console log

* remove console logging

* update plugin related docs

* local solution for windows support

* refactor errant object assign

* full cross platform URL support

* fix lint

* fix extra bundles when custom prerendering

* clean up stale or already tracked TODOs

* add nested head tag smoke tests

* check for app template validation for HUD display

* misc refactoring and TODOs cleanup

* restore static router (again)

* standardize passing correct reference for prerender scripts

* clean up data-gwd-opt markers from final HTML
* auto spread arrays of plugins

* flatten refactoring

* update docs and website content
@thescientist13 thescientist13 changed the base branch from master to release/0.27.0 September 22, 2022 12:45
@thescientist13
Copy link
Member Author

closing in favor of #980

@thescientist13 thescientist13 moved this from IN PROGRESS to DONE in 8 - SSR Enhancements Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.27.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant