Fix build with Boost 1.89.0#7220
Merged
DennisOSRM merged 1 commit intoProject-OSRM:masterfrom Aug 26, 2025
Merged
Conversation
41 tasks
Collaborator
|
consider also bumping the dependency. |
Contributor
Author
Where are you referring to? If CI, it doesn't look like and same thing for Conan: https://conan.io/center/recipes/boost?version=1.88.0 Line 9 in c467cdf For code, it should be backwards compatible as far as I can tell, so there shouldn't be any increase in minimum required Boost. |
DennisOSRM
approved these changes
Aug 25, 2025
Collaborator
|
Thx for the clarification. Looks fine to merge as is and to bump the dependencies when they become available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7219
Used
__has_include(since C++20 standard) though alternative would beBOOST_VERSION < 108900Tasklist
Requirements / Relations
None