Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7601 fix mlflow artifacts #7604

Merged
merged 9 commits into from
Apr 12, 2024
Merged

7601 fix mlflow artifacts #7604

merged 9 commits into from
Apr 12, 2024

Conversation

binliunls
Copy link
Contributor

@binliunls binliunls commented Apr 1, 2024 •
edited by KumoLiu
Loading

Fixes #7601 .

Description

Support not save artifacts.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@binliunls binliunls requested a review from Nic-Ma April 7, 2024 11:04
Nic-Ma
Nic-Ma approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, put minor comments inline.
Please remember to update the associated tutorial notebook.

Thanks.

monai/bundle/utils.py Show resolved Hide resolved
monai/bundle/workflows.py Show resolved Hide resolved
Nic-Ma
Nic-Ma reviewed Apr 10, 2024
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 10, 2024 •
edited
Loading

Hi @KumoLiu ,

Could you please help include this bug fix PR in the MONAI 1.3.1rc3 release?

Thanks in advance.

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 10, 2024

/build

@KumoLiu KumoLiu mentioned this pull request Apr 11, 2024
Closed
@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 11, 2024

/build

@KumoLiu KumoLiu merged commit da3ecdd into Project-MONAI:dev Apr 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default MLFlow tracking cannot set if tracking the config artifacts
3 participants
@binliunls @Nic-Ma @KumoLiu