Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using keys in .npz files for NumpyReader #7148

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Using keys in .npz files for NumpyReader #7148

merged 2 commits into from
Oct 20, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 20, 2023

Fixes #7147.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#7147
ca41425 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
add more test
9d4e50e 
Signed-off-by: KumoLiu <[email protected]>
wyli
wyli approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Oct 20, 2023

/build

@wyli wyli enabled auto-merge (squash) October 20, 2023 08:08
@wyli wyli merged commit 77b1759 into Project-MONAI:dev Oct 20, 2023
28 checks passed
@KumoLiu KumoLiu deleted the numpyreader branch October 20, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: NumpyReader for .npz files with variable names.
2 participants
@KumoLiu @wyli