Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6985 metatensor_to_itk_image compatible space #7000

Merged
merged 4 commits into from
Sep 18, 2023
Merged

6985 metatensor_to_itk_image compatible space #7000

merged 4 commits into from
Sep 18, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 18, 2023 •
edited
Loading

Fixes #6985

Description

  • update metatensor_to_itk_image to accept RAS metatensor
  • nrrdreader default 'space' from empty/"left-posterior-superior" to SpaceKeys.LPS
  • more tests

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
adds new test
4f2da91 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
tested itk
6354bb0 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
more tests
21e741b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review September 18, 2023 11:44
ericspod
ericspod approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, I guess we don't have to consider other space values from NRRD or other files. (Others are mentioned here: https://teem.sourceforge.net/nrrd/format.html#space)

@wyli
Copy link
Contributor Author

wyli commented Sep 18, 2023

/build

@wyli wyli enabled auto-merge (squash) September 18, 2023 12:51
@wyli wyli merged commit b31367f into Project-MONAI:dev Sep 18, 2023
30 of 35 checks passed
@wyli wyli deleted the 6985-itk-image branch November 2, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@KumoLiu KumoLiu Awaiting requested review from KumoLiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

itk_torch_bridge.metatensor_to_itk_image() incorrect orientation
2 participants
@wyli @ericspod