Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lazy=True ignored when using Dataset call #6975

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Fix Lazy=True ignored when using Dataset call #6975

merged 6 commits into from
Sep 13, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 13, 2023

Fixes #6974.

Description

Change default value of lazy in apply_transform to None.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli
wyli approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me. once confirmed, please include a small test and update the docstring.

@KumoLiu
Revert "fix Project-MONAI#6974"
4aa85fc 
This reverts commit 9157e77.
@KumoLiu
add unittests
8d05737 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
update docstring
4133236 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
DCO Remediation Commit for KumoLiu <[email protected]>
889b4ae 
I, KumoLiu <[email protected]>, hereby add my Signed-off-by to this commit: 4aa85fc

Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu marked this pull request as ready for review September 13, 2023 07:34
@wyli
Copy link
Contributor

wyli commented Sep 13, 2023

/build

@wyli wyli enabled auto-merge (squash) September 13, 2023 07:54
@wyli wyli merged commit d4dc055 into Project-MONAI:dev Sep 13, 2023
33 of 37 checks passed
@KumoLiu KumoLiu deleted the lazy branch September 18, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lazy=True ignored when using Dataset call
2 participants
@KumoLiu @wyli