Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4636 4637 backward compatible types #4638

Merged
merged 10 commits into from
Jul 7, 2022
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 6, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #4636
Fixes #4637
Fixes #4639

Description

  • adds track_meta to EnsureType(d)
  • adds astype(...) to MetaTensor

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, rijobro and ericspod and removed request for Nic-Ma and rijobro July 6, 2022 07:59
@wyli wyli changed the title 4637 4638 backward compatible types 4636 4637 backward compatible types Jul 6, 2022
@wyli wyli marked this pull request as ready for review July 6, 2022 09:02
Signed-off-by: Wenqi Li <[email protected]>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jul 6, 2022

Hi @KumoLiu ,

Could you please help take a look at this PR according to your observation in the tutorials?

Thanks in advance.

wyli added 3 commits July 6, 2022 16:50
This reverts commit 379c205.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for 1 minor comment inline.

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Jul 6, 2022

/build

@wyli wyli enabled auto-merge (squash) July 6, 2022 23:56
@wyli wyli merged commit e270741 into Project-MONAI:dev Jul 7, 2022
@wyli wyli deleted the metatensor-types branch July 19, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_to_numpy issue backward compatible EnsureType metatensor supports astype(dtype, device)
3 participants